This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
[QUAD] Deadline: Improve get_publish_plugin_paths to properly get paths for the specified host #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the specified host
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| all_plugin_paths = {} | ||
|
|
||
| for valid_plugin_type in self._valid_plugin_types: | ||
| all_plugin_paths[valid_plugin_type] = self.plugin_paths[valid_plugin_type]['all'] |
| if host in self.plugin_paths[valid_plugin_type]: | ||
| self.plugin_paths[valid_plugin_type][host].append(plugin_path_resolved) | ||
| else: | ||
| self.plugin_paths[valid_plugin_type][host] = [plugin_path_resolved] |
| # Adding the plugin path to the correct host array(s) | ||
| for host in hosts_list: | ||
| if host in self.plugin_paths[valid_plugin_type]: | ||
| self.plugin_paths[valid_plugin_type][host].append(plugin_path_resolved) |
| hosts_list = ast.literal_eval(hosts_str) | ||
|
|
||
| # Adding the plugin path to the "all" array | ||
| self.plugin_paths[valid_plugin_type]['all'].append(plugin_path_resolved) |
| # The regex didn't match, maybe an __init__.py file | ||
| continue | ||
|
|
||
| hosts_str = re.sub(r'\s+', '', match.group(match.lastgroup)) |
ynbot
added
type: enhancement
|
I suppose this is to register only the plug-ins for a particular host. This has been solved in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Paragraphs contain detailed information on the changes made to the product or service, providing an in-depth description of the updates and enhancements. They can be used to explain the reasoning behind the changes, or to highlight the importance of the new features. Paragraphs can often include links to further information or support documentation.
Additional info
Paragraphs of text giving context of additional technical information or code examples.
Testing notes: